Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s example to auth docs #782

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Add k8s example to auth docs #782

merged 2 commits into from
Sep 20, 2023

Conversation

flaviuvadan
Copy link
Collaborator

Pull Request Checklist

Vikram pointed out in the CNCF #hera channel that we no longer have a K8s auth example. This PR adds back the example to the docs

Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
@flaviuvadan flaviuvadan added semver:patch A change requiring a patch version bump type:documentation A documentation update labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #782 (c0df85d) into main (bb3c7c0) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #782   +/-   ##
=====================================
  Coverage   78.2%   78.2%           
=====================================
  Files         45      45           
  Lines       3639    3639           
  Branches     732     732           
=====================================
  Hits        2847    2847           
  Misses       594     594           
  Partials     198     198           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@elliotgunton elliotgunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should add a note about the new dependency that a user would need to install

docs/walk-through/authentication.md Show resolved Hide resolved
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Copy link
Collaborator

@elliotgunton elliotgunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flaviuvadan flaviuvadan merged commit cd253fb into main Sep 20, 2023
15 checks passed
@flaviuvadan flaviuvadan deleted the fv/k8s-auth-example branch September 20, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants